Skip to content

Comments

simplenes: unstable-2019-03-13 -> 0-unstable-2025-01-05#392650

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage:simplenes
Mar 24, 2025
Merged

simplenes: unstable-2019-03-13 -> 0-unstable-2025-01-05#392650
GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage:simplenes

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Mar 24, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage requested a review from kirillrdy March 24, 2025 08:03
Copy link
Member

@kirillrdy kirillrdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried building but diff looks good

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392650


x86_64-linux

✅ 1 package built:
  • simplenes

aarch64-linux

✅ 1 package built:
  • simplenes

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 24, 2025
@GaetanLepage
Copy link
Contributor Author

It doesn't crash at startup. (Though I don't have a ROM to test it).

@GaetanLepage GaetanLepage merged commit 940ba6e into NixOS:master Mar 24, 2025
55 of 59 checks passed
@GaetanLepage GaetanLepage deleted the simplenes branch March 24, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants